ksamaschke/implementation-skills-claude
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(implement-issues): require configured deploy gate #3

Merged
ksamaschke merged 1 commit from fix/2-deploy-gate into main 2026-07-05 18:55:39 +00:00
Conversation 0 Commits 1 Files changed 5 +39 -13
ksamaschke commented 2026-07-05 18:54:38 +00:00
Owner
Copy link

Closes #2

Acceptance criteria:

  • implement-issues Phase 6 is a mandatory deploy gate: matching merged changes require deploy and deploy_verify; missed deploy is failed/incomplete, never success.
  • Phase 7 report requires an explicit deploy row: ran/verified, skipped-with-config-reason, or MISSED (error).
  • Work-item contract and prepare-work require the deployment acceptance criterion for configured deploy_paths matches and for deploy-without-deploy_paths all-file matches.
  • Project config semantics match the gate behavior.

Verification:

  • git diff --check -- README.md plugins/implementation-skills/skills/implement-issues/SKILL.md plugins/implementation-skills/skills/implement-issues/references/work-item-contract.md plugins/implementation-skills/skills/implement-issues/references/project-config.md plugins/implementation-skills/skills/prepare-work/SKILL.md
  • targeted rg gate for deploy gate, failure semantics, report row, deployment AC, and omitted deploy_paths behavior
  • independent requirements check: PASS
  • independent hostile review: no blocking findings; stale summary nit fixed
Closes #2 Acceptance criteria: - [x] `implement-issues` Phase 6 is a mandatory deploy gate: matching merged changes require `deploy` and `deploy_verify`; missed deploy is failed/incomplete, never success. - [x] Phase 7 report requires an explicit deploy row: `ran/verified`, `skipped-with-config-reason`, or `MISSED (error)`. - [x] Work-item contract and `prepare-work` require the deployment acceptance criterion for configured `deploy_paths` matches and for deploy-without-`deploy_paths` all-file matches. - [x] Project config semantics match the gate behavior. Verification: - `git diff --check -- README.md plugins/implementation-skills/skills/implement-issues/SKILL.md plugins/implementation-skills/skills/implement-issues/references/work-item-contract.md plugins/implementation-skills/skills/implement-issues/references/project-config.md plugins/implementation-skills/skills/prepare-work/SKILL.md` - targeted `rg` gate for deploy gate, failure semantics, report row, deployment AC, and omitted `deploy_paths` behavior - independent requirements check: PASS - independent hostile review: no blocking findings; stale summary nit fixed
ksamaschke deleted branch fix/2-deploy-gate 2026-07-05 18:55:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ksamaschke/implementation-skills-claude!3
No description provided.